This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Rename "prettyprint" to "prettyformat"
- From: Doug Evans <dje at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 9 Jul 2013 10:00:42 -0700
- Subject: Re: [patch] Rename "prettyprint" to "prettyformat"
- References: <yjt2sizyat6k dot fsf at ruffy dot mtv dot corp dot google dot com>
On Mon, Jul 1, 2013 at 2:04 PM, Doug Evans <dje@google.com> wrote:
> Hi.
> This patch is basically an internal renaming to remove some of the ambiguity in
> "pretty printing".
>
> The "prettyprinting" in struct value_print_options is now called
> "prettyformatting". The rest of the patch is just fallout from that.
>
> Regression tested on amd64-linux.
>
> I will check this in in a few days if there are no objections.
>
> [I realize we had a discussion before about whether "All callers
> updated." applies to just the one file, or all files.
> There was no decision IIRC, and I prefer the simplicity of this way.]
>
> 2013-07-01 Doug Evans <dje@google.com>
>
> * defs.h (enum val_prettyformat): Renamed from val_prettyprint.
> Enum values rename as well. All uses updated.
> * valprint.h (value_print_options): Rename member pretty to
> pretty format. Rename member prettyprint_arrays to
> prettyformat_arrays. Rename member prettyprint_structs to
> prettyformat_structs. All uses updated.
> (get_no_prettyformat_print_options): Renamed from
> get_raw_print_options.
> * valprint.c (get_no_prettyformat_print_options): Renamed from
> get_raw_print_options. All callers updated.
> (show_prettyformat_structs): Renamed from show_prettyprint_structs.
> All callers updated.
> (show_prettyformat_arrays): Renamed from show_prettyprint_arrays.
> All callers updated.
> (_initialize_valprint): Improve help text for "set print pretty" and
> "set print arrays".
>
> testsuite/
> gdb.base/default.exp: Update expected output of "show print array"
> and "show print pretty".
Committed.