This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/28] introduce CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF and use it
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 15 May 2013 16:57:41 +0100
- Subject: Re: [PATCH 01/28] introduce CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF and use it
- References: <87ehe638ww dot fsf at fleche dot redhat dot com> <87zjwu1tpa dot fsf at fleche dot redhat dot com>
On 04/19/2013 03:27 PM, Tom Tromey wrote:
> --- a/gdb/python/python-internal.h
> +++ b/gdb/python/python-internal.h
> @@ -20,6 +20,13 @@
> #ifndef GDB_PYTHON_INTERNAL_H
> #define GDB_PYTHON_INTERNAL_H
>
> +#ifdef WITH_CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF_ATTRIBUTE
> +#define CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF(ARG) \
> + __attribute__ ((cpychecker_type_object_for_typedef (ARG)))
> +#else
> +#define CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF(ARG)
> +#endif
Could we have a comment here with a short hint at what this is
all about? I assume from the patch that
WITH_CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF_ATTRIBUTE is defined
by cpychecker itself (not autoconf/config.h), but I can see
future readers getting confused.
Thanks,
--
Pedro Alves