This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add -s option to make -break-insert support dprintf
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: tromey at redhat dot com, palves at redhat dot com, hui_zhu at mentor dot com, gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Sat, 11 May 2013 10:28:38 +0300
- Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
- References: <515451EA dot 1000200 at mentor dot com> <83y5d7wpvq dot fsf at gnu dot org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q at mail dot gmail dot com> <516454DA dot 9040109 at redhat dot com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig at mail dot gmail dot com> <87ppxzhfqy dot fsf at fleche dot redhat dot com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig at mail dot gmail dot com> <516C2549 dot 3060808 at redhat dot com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw at mail dot gmail dot com> <87vc7ithtj dot fsf at fleche dot redhat dot com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw at mail dot gmail dot com> <87wqrrll9m dot fsf at fleche dot redhat dot com> <CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ at mail dot gmail dot com> <87d2t2tt02 dot fsf at fleche dot redhat dot com> <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg at mail dot gmail dot com> <87ehdehnc9 dot fsf at fleche dot redhat dot com> <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA at mail dot gmail dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Hui Zhu <teawater@gmail.com>
> Date: Sat, 11 May 2013 10:37:56 +0800
> Cc: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>, Hui Zhu <hui_zhu@mentor.com>,
> gdb-patches ml <gdb-patches@sourceware.org>, Marc Khouzam <marc.khouzam@ericsson.com>
>
> --- a/NEWS
> +++ b/NEWS
> @@ -60,6 +60,8 @@ show debug nios2
> ** The -trace-save MI command can optionally save trace buffer in Common
> Trace Format now.
>
> + ** The new command -dprintf-insert sets a dynamic printf breakpoint.
> +
> *** Changes in GDB 7.6
This part is OK.
> +If specified, @var{location}, can be one of:
> +
> +@itemize @bullet
> +@item function
> +@c @item +offset
> +@c @item -offset
> +@c @item linenum
> +@item filename:linenum
> +@item filename:function
> +@item *address
> +@end itemize
Each of "function", "filename", "linenum", and "address" above
should be in @var{}, because they do not stand for themselves.
> +If @var{location} cannot be parsed (for example if it
^
A comma is missing.
> +refers to unknown files or functions), create a pending
> +breakpoint. Without this flag, @value{GDBN} will report
^^
Two spaces between sentences.
> +@item -i @var{ignore-count}
> +Initialize the @var{ignore-count}.
"Set the ignore count of the breakpoint (@pxref{Conditions, ignore
count}) to @var{ignore-count}."
> +Note: this format is open to change.
Why do we need this note in the manual?
> +The corresponding @value{GDBN} commands are @samp{dprintf}.
^^^^^^^^^^^^
"command is"
Thanks.