Re: [PATCH 00/40] add cleanup checker and fix cleanup bugs

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> Thanks for doing this, I think it is awesome.  I am not going to
Phil> comment on the other thirty nine patches as the fixes are largely
Phil> mechanical in nature.

It wouldn't hurt if someone gave them a second look :)

Phil> Will your cleanup checker run as part of the normal build?
Phil> (or testsuite)?
Phil> (or ARI)?
Phil> Or will it be a manual thing?
Phil> If it is manual, can it be made automatic?

It requires GCC, the GCC Python plugin, and extra arguments to the
compiler to tell it to load the checker script.  So I think it won't
ever be fully automatic.

It is pretty easy to run, though.

I looked just now at having it run using the installed gcc-with-python2,
or using the installed GCC python .so.  I think I can make some more
improvements to make it even simpler.  Though it isn't too hard:

yum install gcc-python2-plugin
make CC='gcc-with-python2 /full/path/to/check_cleanup.py'

Phil> Given the number of errors this tool identified, I think these are
Phil> common logic errors?

Yes.

Phil> What, if any, are the limitations of this, and other, GCC plugins to
Phil> fixing common GDB patterns of errors in a common build scenario?  

The main limitation is the number of false reports it gives.  Also see
patch #36.

Tom