Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability

[Pavel Chupin <pavel dot v dot chupin at gmail dot com>]

On Mon, May 6, 2013 at 4:30 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Mon, 6 May 2013 15:28:14 +0400
>> From: Pavel Chupin <pavel.v.chupin@gmail.com>
>>
>> On Wed, Apr 17, 2013 at 3:21 PM, Pavel Chupin <pavel.v.chupin@gmail.com> wrote:
>> > Hi,
>> > Attached patch adds check for dlfcn.h header availability before
>> > adding -ldl to some configure commands. Otherwise on some
>> > configuration -ldl is added unconditionally even though it's not
>> > required and gdb is configured without ELF support due to failed link.
>> >
>> > Issue is found on mingw gdb build for Android.
>> >
>> > gdb/ChangeLog entry:
>> > 2013-04-16  Pavel Chupin  <pavel.v.chupin@intel.com>
>> >
>> >         Replace hardcoded -ldl with check based on dlfcn.h availability
>> >         * configure.ac: Add dlfcn.h check and DLOPEN_LIBS def.
>> >         * acinclude.m4: Use DLOPEN_LIBS instead of hardcode.
>> >         * configure: Regenerate.
>> >
>>
>> Ping
>
> The fix isn't quite right.  OpenBSD for example has <dlfcn.h> but no
> libdl; dlopen(3) and friends live in libc.

Hi Mark,
Thanks for your comments. Please see new patch attached.

Updated ChangeLog:

2013-05-07  Pavel Chupin  <pavel.v.chupin@intel.com>

        Replace hardcoded -ldl with check for availability
        * acinclude.m4: Add check for dlopen in libdl.
        * configure.ac: Ditto.
        * configure: Regenerate.

--
Pavel Chupin
Intel Corporation

Attachment: 0001-Replace-hardcoded-ldl-with-check-for-availability.patch
Description: Binary data