Re: [patch 3/4] Nios II gdbserver support, version 2

[Pedro Alves <palves at redhat dot com>]

On 05/03/2013 04:45 AM, Sandra Loosemore wrote:
> Here is a revised version of the gdbserver parts of the Nios II port. I've tweaked the copyright dates, comments, and formatting similarly to what I did to the GDB-side patches.  I also made a few cleanups to the register-handling code to be consistent with the technical changes I made on the GDB side.
> 
> OK to commit?

Okay with nits below addressed.

> +static CORE_ADDR
> +nios2_get_pc (struct regcache *regcache)
> +{
> +  union nios2_register pc;

Could you add an empty line after declarations (throughout),
please?

> +ps_err_e
> +ps_get_thread_area (const struct ps_prochandle *ph,
> +                    lwpid_t lwpid, int idx, void **base)
> +{
> +  if (ptrace (PTRACE_GET_THREAD_AREA, lwpid, NULL, base) != 0)
> +    return PS_ERR;
> +
> +  /* IDX is the bias from the thread pointer to the beginning of the
> +     thread descriptor.  It has to be subtracted due to implementation
> +     quirks in libthread_db.  */
> +  *base = (void *) ((char *)*base - idx);

Missing space: '(char *) *base'

> +struct regset_info target_regsets[] = {

Put { on next line.

> +struct linux_target_ops the_low_target = {

Ditto.

Thanks,
-- 
Pedro Alves