This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Maxime Coste <frrrwww at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 30 Apr 2013 11:30:31 +0400
- Subject: Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame
- References: <1367002961-12311-1-git-send-email-frrrwww at gmail dot com> <1367002961-12311-2-git-send-email-frrrwww at gmail dot com> <87r4htxeth dot fsf at fleche dot redhat dot com>
> Maxime> select_frame calls specify if the frame is selected due to
> Maxime> a breakpoint/signal (REASON_STOP), a user command (REASON_USER)
> Maxime> or just as an implementation detail (REASON_IMPL_DETAIL) which
> Maxime> should restore the previous frame once finished.
>
> I don't mind this approach but I would like to hear from other
> maintainers.
I wasn't super fond when I saw this yesterday, TBH, particuarly
after seeing how it's used in the patch. But I haven't really had
time to think this over to see if I can propose something else.
So do not block the patch on my account.
--
Joel