This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Thread exit messages on MS-Windows
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 30 Apr 2013 11:27:25 +0400
- Subject: Re: [RFA] Thread exit messages on MS-Windows
- References: <83obd1tyi7 dot fsf at gnu dot org> <838v44tnf8 dot fsf at gnu dot org> <20130429102100 dot GY3525 at adacore dot com> <83ppxdqs2i dot fsf at gnu dot org>
> I know what to do with Corinna's comment, but not what to decide about
> announcing the death of the main thread. Do you have an opinion?
No strong opinion, but I share your preference.
> My reading of the code is that you already see that in linux-native
> debugging, see linux-nat.c.
'must have missed it... sorry :).
> > One tiny nitpick, very possibly influenced by personal preferences,
> > so feel free to ignore... I think that the code would be faster
> > to read if the added parameter was moved to the next line. That way,
> > all parameters in call to windows_delete_thread would have the same
> > indentation level.
>
> I'm surprised, but I don't mind, and will do that, too.
Then don't. It's such a small comment that it's not worth changing.
--
Joel