This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix multiple-symbols=ask regression [Re: [patchv2 7/11] Mechanical symtab->filename -> symtab_to_filename]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 9 Apr 2013 16:33:34 -0700
- Subject: Re: [patch] Fix multiple-symbols=ask regression [Re: [patchv2 7/11] Mechanical symtab->filename -> symtab_to_filename]
- References: <20130127223538 dot GH15252 at host2 dot jankratochvil dot net> <20130201205628 dot GB21133 at host2 dot jankratochvil dot net> <20130228013639 dot GA12113 at adacore dot com> <20130301191933 dot GA17477 at host2 dot jankratochvil dot net> <20130409151237 dot GA24940 at host2 dot jankratochvil dot net>
> I have implemented the fix but I do not intend to check it in.
>
> I have not found a case where it would display error in the relative form
> (with set filename-display relative) as the errors happen only during
> re-evaluation of ADDR_STRING which is always in absolute form.
>
> And I believe ADDR_STRING should be in the absolute form.
>
> While it may be slightly more correct to keep source_filename split to
> symtab+suffix it complicates the code and I do not think it is worth it.
OK, no problem with me...
--
Joel