Re: [patch 6/6] gdbserver build-id attribute generator

[Gary Benson <gbenson at redhat dot com>]

Aleksandar Ristovski wrote:
> On 13-04-09 07:29 AM, Gary Benson wrote:
> > Aleksandar Ristovski wrote:
> > > (linux_qxfer_libraries_svr4): Add optional build-id attribute
> > > to reply XML document.
> > 
> > For the record this is the only part of your patchset that clashes
> > with the gdbserver work I'm doing.  It's not an *awful* clash, but
> > it will require a manual merge.  I'm happy to do that if necessary.
> 
> Thank you for your update.  I'm sorry for the clash. If there is
> something obvious I can do in this patch to reduce the clash let me
> know.

There's nothing obvious, and you don't need to apologise.  We just
both happen to be working in the same area at the same time.

> BTW, I am not familiar with your patch, if you want you can give me
> an overview here or offline.

The gdbserver side of it is that GDB can pass arguments in the annex
of qXfer:libraries-svr4:read+ to instruct the remote to transfer the
list starting from a specific link map rather than sending the whole
list.

I've attached my work-in-progress patch for the gdbserver side, but
you can see the full thing in the gbenson/rtld-probes branch in archer
git if you like.  A lot of the code is actually the same, but somewhat
reordered and with indentation changes which makes the patch harder to
read.

Your work seems closer to being accepted than mine, so I imagine what
will happen is that you'll commit your patches and I'll rebase mine
on top of that.  I have no problem with that.

Cheers,
Gary

--
http://gbenson.net/

Attachment: gdbserver-changes.patch
Description: Text document