This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix multiple-symbols=ask regression [Re: [patchv2 7/11] Mechanical symtab->filename -> symtab_to_filename]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 9 Apr 2013 17:18:04 +0200
- Subject: Re: [patch] Fix multiple-symbols=ask regression [Re: [patchv2 7/11] Mechanical symtab->filename -> symtab_to_filename]
- References: <20130127223538 dot GH15252 at host2 dot jankratochvil dot net> <20130201205628 dot GB21133 at host2 dot jankratochvil dot net> <20130228013639 dot GA12113 at adacore dot com> <20130301191933 dot GA17477 at host2 dot jankratochvil dot net> <20130409151237 dot GA24940 at host2 dot jankratochvil dot net>
On Tue, 09 Apr 2013 17:12:37 +0200, Jan Kratochvil wrote:
> I have implemented the fix but I do not intend to check it in.
Going to check in just rather this comment.
Jan
gdb/
2013-04-09 Jan Kratochvil <jan.kratochvil@redhat.com>
* linespec.c (convert_linespec_to_sals): New comment for
SOURCE_FILENAME assignment.
diff --git a/gdb/linespec.c b/gdb/linespec.c
index 1c7a7a0..989c8d2 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -2059,6 +2059,10 @@ convert_linespec_to_sals (struct linespec_state *state, linespec_p ls)
{
const char *fullname = symtab_to_fullname (state->default_symtab);
+ /* It may be more appropriate to keep DEFAULT_SYMTAB in its symtab
+ form so that displaying SOURCE_FILENAME can follow the current
+ FILENAME_DISPLAY_STRING setting. But as it is used only rarely
+ it has been kept for code simplicity only in absolute form. */
ls->source_filename = xstrdup (fullname);
}
}