This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Include putpkt in TRY_CATCH. PR gdb/15275


On 03/29/2013 02:02 PM, Jan Kratochvil wrote:
> On Thu, 28 Mar 2013 18:07:10 +0100, Pedro Alves wrote:
>> And detaching should
>> delete breakpoints from the target before sending "D" (although detach
>> command does, a detach caused by "quit" doesn't (if you "gdbserver --attach",
> 
> I see it working:

Whoops.  I remembered incorrectly where we're removing breakpoints.

>> gdb/
>> 2013-03-28  Pedro Alves  <palves@redhat.com>
>>
>> 	PR gdb/15275
>>
>> 	* remote.c (send_interrupt_sequence): Use remote_serial_write.
>> 	(remote_serial_write): New function.
>> 	(putpkt_binary, getpkt_or_notif_sane_1): Use remote_serial_write.
> 
> I agree this fix is better.  I will revert the previous check-in after this
> check-in.

Now pushed.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]