This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] dwarf2read: Fix open_and_init_dwp_file cleanup


Hi.
I happened to notice this.
The cleanup function and argument are incompatible,
but the cleanup isn't really necessary anyway,
so I deleted it.

2013-03-29  Doug Evans  <dje@google.com>

	* dwarf2read.c (open_and_init_dwp_file): Remove incorrect, and
	unnecessary, cleanup.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.768
diff -u -p -r1.768 dwarf2read.c
--- dwarf2read.c	29 Mar 2013 18:46:07 -0000	1.768
+++ dwarf2read.c	29 Mar 2013 21:24:00 -0000
@@ -9198,8 +9210,6 @@ open_and_init_dwp_file (const char *comp
   dwp_file->dbfd = dbfd;
   do_cleanups (cleanups);
 
-  cleanups = make_cleanup (free_dwo_file_cleanup, dwp_file);
-
   /* +1: section 0 is unused */
   dwp_file->num_sections = bfd_count_sections (dbfd) + 1;
   dwp_file->elf_sections =
@@ -9214,8 +9224,6 @@ open_and_init_dwp_file (const char *comp
 
   dwp_file->loaded_cutus = allocate_dwp_loaded_cutus_table (objfile);
 
-  discard_cleanups (cleanups);
-
   if (dwarf2_read_debug)
     {
       fprintf_unfiltered (gdb_stdlog, "DWP file found: %s\n", dwp_file->name);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]