This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 6/6] gdbserver build-id attribute generator

From: Aleksandar Ristovski <aristovski at qnx dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Wed, 27 Mar 2013 10:38:29 -0400
Subject: Re: [patch 6/6] gdbserver build-id attribute generator
References: <51278984 dot 3070208 at qnx dot com> <20130310210843 dot GG21130 at host2 dot jankratochvil dot net> <514C56D4 dot 1060906 at qnx dot com> <20130326204157 dot GC12291 at host2 dot jankratochvil dot net>

On 13-03-26 04:41 PM, Jan Kratochvil wrote:

>+
>+  if (build_id_list_p)
>+    qsort (VEC_address (build_id_list_s, data.list),
>+	   VEC_length (build_id_list_s, data.list),
>+	   sizeof (build_id_list_s), compare_build_id_list);

It is always already sorted by Linux kernel, rather a for cycle to verify it
really is sorted.

Can we guarantee this is always the case? Even if it is, qsort would dosimilar to what a loop would (i.e. no moves would take place).


I'd leave it with qsort unless you feel strongly about it.

Follow-Ups:
- Re: [patch 6/6] gdbserver build-id attribute generator
  - From: Jan Kratochvil

References:
- [draft patch 6/6] gdbserver build-id attribute generator (unfixed)
  - From: Jan Kratochvil
- Re: [patch 6/6] gdbserver build-id attribute generator
  - From: Aleksandar Ristovski
- Re: [patch 6/6] gdbserver build-id attribute generator
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]