This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "set record instruction-history" ?
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 27 Mar 2013 09:32:35 +0000
- Subject: Re: "set record instruction-history" ?
- References: <51507403 dot 6030208 at redhat dot com> <A78C989F6D9628469189715575E55B2307BA7E4F at IRSMSX102 dot ger dot corp dot intel dot com> <51508D60 dot 6040906 at redhat dot com> <A78C989F6D9628469189715575E55B2307BA822E at IRSMSX102 dot ger dot corp dot intel dot com> <5151836D dot 90401 at redhat dot com> <A78C989F6D9628469189715575E55B2307BA8418 at IRSMSX102 dot ger dot corp dot intel dot com> <5151E3BE dot 90603 at redhat dot com> <A78C989F6D9628469189715575E55B2307BA8B86 at IRSMSX102 dot ger dot corp dot intel dot com>
On 03/27/2013 07:53 AM, Metzger, Markus T wrote:
> There is a single regression...
:-(
> record: fix instruction-history-size regression
>
> (gdb) PASS: gdb.btrace/instruction_history.exp: set record instruction-history-size 0
> record instruction-history 0
> Bad range.
> (gdb) FAIL: gdb.btrace/instruction_history.exp: record instruction-history - unlimited
>
> 2013-03-13 Markus Metzger <markus.t.metzger@intel.com>
>
> * record.c (command_size_to_target_size): Fix size comparison.
> Change parameter type from pointer to integer to integer.
> Update all users.
> OK to commit?
Certainly. Thanks for fixing this up.
> Does this also go onto the 7.6 branch?
Mine's not on 7.6 yet. I'll take care of that.
I'm going through all commands (and almost done at that) and will
look over all changes and merge back to 7.6 those that make sense.
--
Pedro Alves