This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MinGW-w64]Build gdb/ctf.c failed
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, asmwarrior <asmwarrior at gmail dot com>, tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 25 Mar 2013 09:28:39 +0100
- Subject: Re: [MinGW-w64]Build gdb/ctf.c failed
- References: <83ip4s4ixc dot fsf at gnu dot org> <1363407692-18959-1-git-send-email-yao at codesourcery dot com> <1363407692-18959-4-git-send-email-yao at codesourcery dot com> <CADPb22RwSq0iv_gQu5PSGezQoUy0ve16M2hmL51HvM19v0M5Ow at mail dot gmail dot com> <51492077 dot 30307 at codesourcery dot com> <83sj3qyogk dot fsf at gnu dot org> <87vc8m7z1d dot fsf at fleche dot redhat dot com> <514FA117 dot 9030604 at gmail dot com> <83hajz3oef dot fsf at gnu dot org> <CAEwic4Y020-LqwtNeYFXn3oQvk5fWBFm1T5ZoAmwqPSpD=PASg at mail dot gmail dot com> <515009B1 dot 5030500 at codesourcery dot com>
2013/3/25 Yao Qi <yao@codesourcery.com>:
> On 03/25/2013 04:06 PM, Kai Tietz wrote:
>> The function 'mkdir' (please note it is without leading underscore),
>> is declared in io.h header, which is of course include within unistd.h
>> header.
>
> Right, 'mkdir' is declared io.h, which is included in unistd.h. Looks
> like we should use "mkdir" instead of "_mkdir". How about the patch
> below? It unbreaks the build of using mingw-w64 toolchain, while
> mingw32 toolchain doesn't complain about it.
I can't approve it, but it looks fine to me.
Thanks,
Kai