Re: Recent simulator patches broke many sims

[Joel Sherrill <joel dot sherrill at oarcorp dot com>]

This came in after I was done email last night. My test
run finished overnight with no horribly bad issues. I have no idea
what the make check results should be though and they could be
because I simply ran "make check" with no board specified and
no gcc for the target installed.

There were some unexpected failures but I don't know what "truth"
on that is.  I have saved logs from the test run and will do so with
the run on Mike's patch.

Starting another test run with Mike's patch.

I can put both sets of logs on an ftp server if someone wants to review
them.  Guidance on what is a bad number of "unexpected failures" on
a target is appreciated.

--joel

On 3/23/2013 9:57 PM, Mike Frysinger wrote:
> On Saturday 23 March 2013 19:38:34 Joel Sherrill wrote:
> > I have a fix. The case for *mingw* and disabling
> > setting SIM_AC_OPTION_HARDWARE needed to
> > be outside the AC_ARG_ENABLE() for --enable-sim-hardware
> > to account for the "always" simulators.
> the way this code is written, the lack of indentation just gets in the way.
> also doing all this processing in the 3rd arg to AC_ARG_ENABLE() is largely
> pointless.
>
> this should do it i think
> -mike
>
> --- a/sim/common/acinclude.m4
> +++ b/sim/common/acinclude.m4
> @@ -609,30 +609,38 @@ dnl arg[3] is a space separated list of extra target specific devices.
>   AC_DEFUN([SIM_AC_OPTION_HARDWARE],
>   [
>   if test x"[$1]" != x"no"; then
> -  sim_hw_p=yes
> +  enable_sim_hardware=yes
>   else
> -  sim_hw_p=no
> +  enable_sim_hardware=no
>   fi
> +
>   if test "[$2]"; then
>     hardware="[$2]"
>   else
>     hardware="cfi core pal glue"
>   fi
>   hardware="$hardware [$3]"
> +
>   sim_hw_cflags="-DWITH_HW=1"
>   sim_hw="$hardware"
>   sim_hw_objs="\$(SIM_COMMON_HW_OBJS) `echo $sim_hw | sed -e 's/\([[^ ]][[^ ]]*\)/dv-\1.o/g'`"
> +
>   AC_ARG_ENABLE(sim-hardware,
> -[  --enable-sim-hardware=LIST		Specify the hardware to be included in the build.],
> -[
> -case "${enableval}" in
> -  yes)	sim_hw_p=yes;;
> -  no)	sim_hw_p=no;;
> +  [AS_HELP_STRING([--enable-sim-hardware=LIST],
> +                  [Specify the hardware to be included in the build.])])
> +case ${enable_sim_hardware} in
> +  yes)  sim_hw_p=yes;;
> +  no)   sim_hw_p=no;;
>     ,*)   sim_hw_p=yes; hardware="${hardware} `echo ${enableval} | sed -e 's/,/ /'`";;
>     *,)   sim_hw_p=yes; hardware="`echo ${enableval} | sed -e 's/,/ /'` ${hardware}";;
> -  *)	sim_hw_p=yes; hardware="`echo ${enableval} | sed -e 's/,/ /'`"'';;
> +  *)    sim_hw_p=yes; hardware="`echo ${enableval} | sed -e 's/,/ /'`"'';;
>   esac
> +
>   if test "$sim_hw_p" != yes; then
> +  if test "[$1]" = "always"; then
> +    AC_MSG_ERROR([Sorry, but this simulator requires that hardware support
> +be enabled. Please configure without --disable-hw-support.])
> +  fi
>     sim_hw_objs=
>     sim_hw_cflags="-DWITH_HW=0"
>     sim_hw=
> @@ -657,26 +665,14 @@ else
>          ;;
>     esac
>     AC_SUBST(SIM_DV_SOCKSER_O)
> -fi
> -if test x"$silent" != x"yes" && test "$sim_hw_p" = "yes"; then
> -  echo "Setting hardware to $sim_hw_cflags, $sim_hw, $sim_hw_objs"
> -fi],[
> -if test "$sim_hw_p" != yes; then
> -  if test "[$1]" = "always"; then
> -    AC_MSG_ERROR([Sorry, but this simulator requires that hardware support
> -be enabled. Please configure without --disable-hw-support.])
> +  if test x"$silent" != x"yes"; then
> +    echo "Setting hardware to $sim_hw_cflags, $sim_hw, $sim_hw_objs"
>     fi
> -  sim_hw_objs=
> -  sim_hw_cflags="-DWITH_HW=0"
> -  sim_hw=
> +  dnl Some devices require extra libraries.
> +  case " $hardware " in
> +    *" cfi "*) AC_CHECK_LIB(m, log2);;
> +  esac
>   fi
> -if test x"$silent" != x"yes"; then
> -  echo "Setting hardware to $sim_hw_cflags, $sim_hw, $sim_hw_objs"
> -fi])
> -dnl Some devices require extra libraries.
> -case " $hardware " in
> -  *" cfi "*) AC_CHECK_LIB(m, log2);;
> -esac
>   ])
>   AC_SUBST(sim_hw_cflags)
>   AC_SUBST(sim_hw_objs)


--
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985