This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] 1 of 5 - Frame filter Python C code changes.
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 22 Mar 2013 07:33:15 -0600
- Subject: Re: [patch][python] 1 of 5 - Frame filter Python C code changes.
- References: <513E56EC dot 2050802 at redhat dot com> <87vc8kzd5d dot fsf at fleche dot redhat dot com>
Phil> + else:
Phil> + # The end argument for islice is a count, not a position, so
Phil> + # add one as frames start at zero.
Phil> + frame_high = frame_high + 1;
Tom> I think it isn't a "count", since otherwise you'd have to subtract
Tom> frame_low.
Ok, I looked at the CLI patch and it seems to be passing in "count"
here. So maybe this note can be addressed by renaming the parameter.
Tom