This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] windows-nat.c: Fix offset problem in signal string handling
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 20 Mar 2013 09:51:24 +0100
- Subject: Re: [patch] windows-nat.c: Fix offset problem in signal string handling
- References: <20130319151436 dot GB20727 at calimero dot vinschen dot de> <20130319212554 dot GE4506 at adacore dot com>
- Reply-to: gdb-patches at sourceware dot org
On Mar 19 14:25, Joel Brobecker wrote:
> > Alternatively the call to string_to_core_addr could be replaced with a
> > call to `strtoull (p, NULL, 0)'. Since this code is only supported on
> > Cygwin, it's safe to assume that the strtoull function exists.
>
> I would go for that option, mostly because you already use strtol
> to parse the beginning of that string...
>
> > Version 2:
> >
> > * windows-nat.c (handle_output_debug_string): Replace call
> > to string_to_core_addr with call to strtoull.
Thanks, applied.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat