Re: [patch, simulator] Fix sim_command_completer arguments.

[Pedro Alves <palves at redhat dot com>]

On 03/15/2013 05:31 PM, Steve Ellcey wrote:
> My build of gdb and sim have recently started failing with:
> 
> /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c: In function '_initialize_remote_sim':
> /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c:1323: error: passing argument 2 of 'set_cmd_completer' from incompatible pointer type
> /local/home/sellcey/nightly2/src/gdb/gdb/command.h:161: note: expected 'struct VEC_char_ptr * (*)(struct cmd_list_element *, const char *, const char *)' but argument is of type 'struct VEC_char_ptr * (*)(struct cmd_list_element *, char *, char *)'
> 
> I didn't see any change in gdb/sim that might be causing this but I am
> building with the latest (ToT) GCC and I think a change there might have
> caused GCC to start catching this discrepency in argument types.  

Actually, the completers prototype only got that "const" this week, and
I missed that there were completers in the sim:

 http://sourceware.org/ml/gdb-patches/2013-03/msg00572.html

Sorry about that.

> I would
> like to fix it by adding the 'const' modifier to the sim_command_completer
> text and word arguments so that its argument types match filename_completer,
> expression_completer, etc.

That's the right fix, thanks.

-- 
Pedro Alves