This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix remote.c incorrectly using pop_target (wrt btrace)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Date: Mon, 11 Mar 2013 10:46:00 -0700
- Subject: Re: [patch] Fix remote.c incorrectly using pop_target (wrt btrace)
- References: <20130311172836.GA22575@host2.jankratochvil.net>
> I would like to get it checked in for 7.6 is it is some sort of regression
> from btrace.
Agreed on getting this fixed before 7.6 gets released. I propose
we still go ahead with the branch tomorrow, and just port the fix
to the branch as soon as approved.
> gdb/
> 2013-03-11 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * remote.c (remote_unpush_target): New function.
> (remote_open_1): Remove two pop_target calls, update one comment, add
> comment to target_preopen call. Replace pop_target call by
> remote_unpush_target call.
> (interrupt_query, readchar, getpkt_or_notif_sane_1): Replace
> pop_target calls by remote_unpush_target calls.
--
Joel