This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix agent code generate bug of ref

From: Tom Tromey <tromey at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: Hui Zhu <teawater at gmail dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Joel Brobecker <brobecker at adacore dot com>
Date: Mon, 11 Mar 2013 08:38:38 -0600
Subject: Re: [PATCH] Fix agent code generate bug of ref
References: <CANFwon0GXGwSqOyev+te3f0DBCqG3y0ovJ+yJ-kcaWkMAJOwXw@mail.gmail.com> <513DDE2C.9080109@codesourcery.com>

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> SIZE is checked as "size in bits".  Your fix is right, but not
Yao> complete. We also have to fix it when op is DW_OP_deref_size,
Yao> something like the patch below.

Yao> I am not familiar with this area, so I might be wrong.

You are correct, but IMO it is simpler to divide each of the case
constants by 8.

Tom

Follow-Ups:
- Re: [PATCH] Fix agent code generate bug of ref
  - From: Tom Tromey
- Re: [PATCH] Fix agent code generate bug of ref
  - From: Hui Zhu

References:
- [PATCH] Fix agent code generate bug of ref
  - From: Hui Zhu
- Re: [PATCH] Fix agent code generate bug of ref
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]