This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger at gmail dot com" <markus dot t dot metzger at gmail dot com>, "Himpel, Christian" <christian dot himpel at intel dot com>
Date: Fri, 8 Mar 2013 14:33:03 +0100
Subject: Re: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests
References: <1362734168-1725-1-git-send-email-markus.t.metzger@intel.com> <1362734168-1725-21-git-send-email-markus.t.metzger@intel.com> <20130308132146.GA12958@host2.jankratochvil.net> <A78C989F6D9628469189715575E55B2307B9D00F@IRSMSX102.ger.corp.intel.com>

On Fri, 08 Mar 2013 14:27:44 +0100, Metzger, Markus T wrote:
> > > +  /* loop is declared in x86-instruction_history.S */
> > 
> > /* loop is defined in 'instruction_history.S'.  */
> 
> I got the feedback in a review of the earlier btrace tests that x86-specific
> assembly files need to be prefixed with either x86-, ia32-, or amd64- depending
> on the architecture for which they are intended.

OK but the file is already renamed in the patch.  BTW the ChangeLog is not
updated for the rename:
        * gdb.btrace/x86-instruction_history.S: New file.
->
        * gdb.btrace/instruction_history.S: New file.

I won't argue against another maintainer opinion, follow either way you
prefer.  Just the code comment should contain the name actually used in the
patch.


Thanks,
Jan

References:
- [patch v10 00/21] branch tracing for Atom
  - From: Markus Metzger
- [patch v10 20/21] testsuite, gdb.btrace: add btrace tests
  - From: Markus Metzger
- Re: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests
  - From: Jan Kratochvil
- RE: [patch v10 20/21] testsuite, gdb.btrace: add btrace tests
  - From: Metzger, Markus T

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]