This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Fix off-by-two "duplicate request for X ignored." [Re: [patch] Fix multiple-symbols=ask regression]
On Mon, 04 Mar 2013 18:39:24 +0100, Jan Kratochvil wrote:
> [0] cancel
> [1] all
> [2] /home/jkratoch/t/overload.C:f()
> [3] /home/jkratoch/t/overload.C:f(int)
> > 2 2
> duplicate request for 0 ignored.
>
> NULL is there to detected the second "2" entry.
> (BTW GDB has a bug, it should print "duplicate request for 2 ignored.", I will
> check in a fix after this patch is done.)
Fixed that one, checked in as obvious.
Jan
http://sourceware.org/ml/gdb-cvs/2013-03/msg00019.html
--- src/gdb/ChangeLog 2013/03/04 19:30:24 1.15203
+++ src/gdb/ChangeLog 2013/03/04 19:38:02 1.15204
@@ -1,5 +1,9 @@
2013-03-04 Jan Kratochvil <jan.kratochvil@redhat.com>
+ * linespec.c (decode_line_2): Fix duplicate request off by two message.
+
+2013-03-04 Jan Kratochvil <jan.kratochvil@redhat.com>
+
* linespec.c (struct linespec_canonical_name): New.
(struct linespec_state): Change canonical_names type to it.
(add_sal_to_sals): Change variable canonical_name to canonical. Change
--- src/gdb/linespec.c 2013/03/04 19:30:25 1.177
+++ src/gdb/linespec.c 2013/03/04 19:38:02 1.178
@@ -1461,7 +1461,7 @@
else
{
printf_unfiltered (_("duplicate request for %d ignored.\n"),
- num);
+ num + 2);
}
}
}