Re: [RFC/TileGX 2/2] fix gdbserver bug for 32bit elf

[Jiong Wang <jiwang at tilera dot com>]

ä 2013/2/27 22:06, Pedro Alves åé:
> On 02/27/2013 04:26 AM, Jiong Wang wrote:
> > at 2013/2/27 2:08, Pedro Alves written:
> > > You mention the 'pc' as a pseudo register.  At the
> > > hardware/kernel level, on tilegx32, is 'pc' 32-bit or 64-bit?
> > > I thought Tile-GX was always 64-bit, and tilegx32 was just an ABI.
> >        thanks for review these.
> >
> >        yes, exactly, TileGX is always 64bit.  On tilegx32, at hardware/kernel level, 'pc' is 64bit.
> > > Is the kernel already trimming the PC?
> >       No trimming, the kernel always return 64bit.
> Oh well.  Makes me feel even more this isn't the best approach, but,
>
> >       below is the updated ChangeLog, and patch.
> >
> >       please review. thanks.
> >
> >       gdb/
> >
> >         * regformats/reg-tilegx.dat (name): Change abi name to "tilegx".
> >         * regformats/reg-tilegx32.dat: New.
> >
> >       gdb/gdbserver/
> >
> >          * Makefile.in (clean): Remove reg-tilegx.c, reg-tilegx32.c.
> >          (reg-tilegx32.c): New rule.
> >          * configure.srv (tilegx-*-linux*): Add reg-tilegx32.o to srv_regobj.
> >          * linux-tile-low.c (tile_arch_steup): New function.  Invoke
> Typo: "setup".
>
> >          different register info initializer according to elf class.
> >          (init_registers_tilgx32): New function.  The tilegx32 register info
> >          initializer.
> >          (tile_fill_gregset): Use "uint_reg_t" to represent register size.
> >          (tile_store_gregset): Likewise.
> OK.

thanks, I will commit this after fixing typo.

Regards,
Jiong
>