This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] null ptr check to prevent gdbserver from crashing


On 02/06/2013 03:27 PM, Pedro Alves wrote:
> On 12/20/2012 09:09 AM, Sanimir Agovic wrote:
>> Evaluating a thread local storage variable in a remote scenario crashes
>> gdbserver if libthread-db could not be loaded.
>>
>> 2012-12-18 Sanimir Agovic <sanimir.agovic@intel.com>
> 
> Note there should be two spaces before and after your name.
> 
>>
>> gdbserver/
>> 	* thread-db.c (thread_db_get_tls_address):
>> 	NULL pointer check thread_db.
>>
>> testsuite/
>> 	* gdb.server/no-thread-db.exp: New file.
>> 	* gdb.server/no-thread-db.c: New file.
>> 	* gdb.server/Makefile.in (EXECUTABLES): Add no-thread-db.
> 
> Thanks.  This is OK.
> 
>> +++ b/gdb/testsuite/gdb.server/no-thread-db.c
>> @@ -0,0 +1,28 @@
>> +/* This testcase is part of GDB, the GNU debugger.
>> +
>> +   Copyright 2012 Free Software Foundation, Inc.
> 
> Remember to update copyright years.
> 

I went ahead and checked this in.  Thanks again.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]