This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64-linux-tdep support
- From: Pedro Alves <palves at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 25 Jan 2013 18:13:08 +0000
- Subject: Re: [PATCH] aarch64-linux-tdep support
- References: <50FED270.5040807@arm.com>
On 01/22/2013 05:54 PM, Marcus Shawcroft wrote:
> + struct rt_sigframe
> + {
> + siginfo_t info;
> + struct ucontext uc;
> + };
> +
> + typeef struct
> + {
> + ... 128 bytes
> + } siginfo_t;
> +
> + The ucontext has the following form:
> + struct ucontext {
> + unsigned long uc_flags;
> + struct ucontext *uc_link;
> + stack_t uc_stack;
> + sigset_t uc_sigmask;
> + struct sigcontext uc_mcontext;
> + };
> +
> + typedef struct sigaltstack {
> + void *ss_sp;
> + int ss_flags;
> + size_t ss_size;
> + } stack_t;
> +
> + struct sigcontext {
> + unsigned long fault_address;
> + unsigned long regs[31];
> + unsigned long sp; / * 31 * /
> + unsigned long pc; / * 32 * /
> + unsigned long pstate; / * 33 * /
> + __u8 __reserved[4096]
> + };
Tabs/spaces/indenting in this comment looks inconsistent.
Typo "typeef".
Otherwise looks good to me.
--
Pedro Alves