This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 7/9] Fix psymtab.c for real and absolute filenames
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 23 Jan 2013 14:31:30 -0700
- Subject: Re: [patch 7/9] Fix psymtab.c for real and absolute filenames
- References: <20130117222339.GH16249@host2.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> partial symtabs did not handle correctly absolute filenames and they had
Jan> problems also with expansion on symlinks.
Jan> + if (!(*file_matcher) (psymtab_to_fullname (ps), data)
Jan> + && !(*file_matcher) (psymtab_to_realname (ps), data))
Jan> continue;
Doesn't this tend to eliminate the benefit of using xfullpath?
Aside from this it looks fine.
Tom