This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] [patch] Fix gdb.fortran/common-block.exp crash in PIE mode
On Mon, 21 Jan 2013 17:12:49 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> Fix gdb.fortran/common-block.exp crash in PIE mode.
> Jan> * dwarf2read.c (new_symbol_full) <DW_TAG_common_block>: Use
> Jan> LOC_COMMON_BLOCK.
> Jan> * f-valprint.c (info_common_command_for_block): Expect
> Jan> LOC_COMMON_BLOCK in gdb_assert.
> Jan> * symtab.h (struct general_symbol_info): Update comment for the
> Jan> common_block member.
> Jan> (domain_enum): Extend comment for the COMMON_BLOCK_DOMAIN member.
> Jan> (enum address_class): New member LOC_COMMON_BLOCK.
>
> Looks good to me.
Checked in:
http://sourceware.org/ml/gdb-cvs/2013-01/msg00123.html
> Perhaps the various symbol-value accessors like SYMBOL_VALUE_ADDRESS
> should make assertions about the address class. This is what GCC does
> in its tree accessors.
OK, I see no need for ({...}), I will post something later.
Thanks,
Jan