This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Add a test case for the jit-reader interface.

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Sanjoy Das <sanjoy at playingwithpointers dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 14 Jan 2013 04:52:08 +0100
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
References: <1352048631-25042-1-git-send-email-sanjoy@playingwithpointers.com> <1352048631-25042-4-git-send-email-sanjoy@playingwithpointers.com> <20121201204751.GB22812@host2.jankratochvil.net> <CAMiUf7f5EXkxi7hD4Rm1bU=_tUUtB3vgLbvzB4S-qbWYgh4_fQ@mail.gmail.com> <20121210163800.GA24342@host2.jankratochvil.net> <CAMiUf7dcxE-nt7OYd2RrKTeMGBBb0-1Buod+KKsYrdu1JYJFTg@mail.gmail.com> <20130109123706.GB6415@host2.jankratochvil.net> <CAMiUf7dQcTnY0XtTS7UL85+gjok3NW5XUzrmd8YoUTW4EHQFYw@mail.gmail.com>

On Sun, 13 Jan 2013 22:57:34 +0100, Sanjoy Das wrote:
> 2. Use SLASH_STRING instead of a raw backslash when computing the full
> path of a plugin (in the second patch).

I have considered it pre-approved for a commit with the few changes.

But I see you can improve:
+    so_name = xstrprintf ("%s%s%s", SLASH_STRING, jit_reader_dir, args);
->
+    so_name = xstrprintf ("%s" SLASH_STRING "%s", jit_reader_dir, args);

So the patchset is approved again with this change.


Thanks,
Jan

References:
- Re: [PATCH 3/3] Add a test case for the jit-reader interface.
  - From: Sanjoy Das
- Re: [PATCH 3/3] Add a test case for the jit-reader interface.
  - From: Jan Kratochvil
- Re: [PATCH 3/3] Add a test case for the jit-reader interface.
  - From: Sanjoy Das

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]