This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, gdbserver] Pass tracepoint to 'add_traceframe_block'.


Hi Yao,

A cross link to the other thread would have been helpful:
http://sourceware.org/ml/gdb-patches/2012-12/msg00368.html

I replied on that other thread.  If going this route, the
code in this patch looks fine.

On 12/20/2012 02:52 AM, Yao Qi wrote:

> Note that after this patch, GDB will get the correct value of
> hit_count and traceframe_usage by means of command 'tstatus', so
> tracepoint 'hit count' should appear in the output of 'info
> tracepoints'.  gdb.trace/tstatus.exp is updated in this patch to check
> 'hit count' and 'traceframe usage' unconditionally.

But what about:

> -    # Tracepoint hit count is optional, so pass it either way.
> -

?

And it seems like traceframe usage as just as optional as
hit count, both being reported by qTP, which the target
may not implement?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]