This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/commit 3/3] Delete unused variable in lynx_resume
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 04 Jan 2013 20:39:32 +0000
- Subject: Re: [RFC/commit 3/3] Delete unused variable in lynx_resume
- References: <1355741951-16867-1-git-send-email-brobecker@adacore.com> <1355741951-16867-3-git-send-email-brobecker@adacore.com>
On 12/17/2012 10:59 AM, Joel Brobecker wrote:
> Hello,
>
> This patch eliminates a local variable that we never use.
> It is an RFC, because I couldn't determine whether there was
> something we were expected to do if the ptrace request failed
> - which has never happened to us so far, AFAICT.
Error handling in gdbserver is poor. The Windows ports
ignore errors (I think errors there would be very rare).
The Linux ports do error out, see bottom of linux_resume_one_lwp.
>
> gdb/gdbserver/ChangeLog:
>
> * lynx-low.c (lynx_resume): Delete variable ret.
>
> Tested on ppc-lynx5. OK to commit, or is there some error handling
> protocol?
>
> Thanks,
>
--
Pedro Alves