This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch v6 02/12] cli, btrace: add btrace cli

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
Cc: "palves at redhat dot com" <palves at redhat dot com>, "tromey at redhat dot com" <tromey at redhat dot com>, "kettenis at gnu dot org" <kettenis at gnu dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger at gmail dot com" <markus dot t dot metzger at gmail dot com>
Date: Tue, 18 Dec 2012 09:35:09 +0100
Subject: Re: [patch v6 02/12] cli, btrace: add btrace cli
References: <1355760101-26237-1-git-send-email-markus.t.metzger@intel.com> <1355760101-26237-3-git-send-email-markus.t.metzger@intel.com> <20121217183214.GA14232@host2.jankratochvil.net> <A78C989F6D9628469189715575E55B2307B41FDC@IRSMSX102.ger.corp.intel.com>

On Tue, 18 Dec 2012 08:36:47 +0100, Metzger, Markus T wrote:
> I didn't use gdb_assert since this is not checking gdb's internal state. Gdb
> would still function correctly even if we saw such unexpected trace.

Sorry, I read a later patch where the data is read from XML from gdbserver so
I agree it should not be gdb_assert.

> > No need for a repost wrt the changes above.
> 
> Does that mean you approve the patch?

Not yet, going to post yet a [patch 00/12] reply.

Thanks,
Jan

References:
- [patch v6 00/12] branch tracing support for Atom
  - From: markus . t . metzger
- [patch v6 02/12] cli, btrace: add btrace cli
  - From: markus . t . metzger
- Re: [patch v6 02/12] cli, btrace: add btrace cli
  - From: Jan Kratochvil
- RE: [patch v6 02/12] cli, btrace: add btrace cli
  - From: Metzger, Markus T

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]