ping: [PATCH] Add fseek to ui-file

[Hui Zhu <teawater at gmail dot com>]

Ping.

Thanks,
Hui

---------- Forwarded message ----------
From: Hui Zhu <teawater@gmail.com>
Date: Tue, Dec 11, 2012 at 3:21 PM
Subject: Re: [PATCH] Add fseek to ui-file
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>, Hui Zhu <hui_zhu@mentor.com>


On Tue, Dec 11, 2012 at 3:55 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> Post a patch for that.  Please help me review it.
>
> I think _p is not a super choice for a suffix.
> It already has a meaning in gdb.
> "_ptr" or most anything else would be better.
>
> Tom

Post a new version.  Please help me review it.

Thanks,
Hui

2012-12-11  Hui Zhu  <hui_zhu@mentor.com>

        * ui-file.c (set_ui_file_flush): Change flush to flush_ptr.
        (set_ui_file_isatty): Change isatty to isatty_ptr.
        (set_ui_file_rewind): Change rewind to rewind_ptr.
        (set_ui_file_put): Change put to put_ptr.
        (set_ui_file_write): Change write to write_ptr.
        (set_ui_file_write_async_safe): Change write_async_safe to
        write_async_safe_ptr.
        (set_ui_file_read): Change read to read_ptr.
        (set_ui_file_fputs): Change fputs to fputs_ptr.
        (set_ui_file_data): Change delete to delete_ptr.

Attachment: ui-file-change-arg.txt
Description: Text document