This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC-v5] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior)
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'asmwarrior'" <asmwarrior at gmail dot com>, "'Joel Brobecker'" <brobecker at adacore dot com>, "'Eli Zaretskii'" <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Thu, 13 Dec 2012 11:07:12 +0000
- Subject: Re: [RFC-v5] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior)
- References: <20121024194517.GK3555@adacore.com> <011901cdb2ab$48076b90$d81642b0$@muller@ics-cnrs.unistra.fr> <20121105171121.GA2972@adacore.com> <50991f5f.8382440a.1100.ffff82abSMTPIN_ADDED@mx.google.com> <509ABA17.30507@redhat.com> <000301cdbd96$f5cd9f10$e168dd30$@muller@ics-cnrs.unistra.fr> <20121122173019.GF9964@adacore.com> <15690.5992342674$1353883881@news.gmane.org> <87624si9ur.fsf@fleche.redhat.com> <001501cdccaf$ad85e9b0$0891bd10$@muller@ics-cnrs.unistra.fr> <20121207071035.GG31477@adacore.com> <50C20A66.70002@gmail.com> <29545.4593528577$1354894901@news.gmane.org> <50C21696.7040006@gmail.com> <50c21914.a750420a.2ec3.ffffe4ffSMTPIN_ADDED_BROKEN@mx.google.com> <50C222D5.4000802@redhat.com> <50C22C20.8090906@redhat.com> <008101cdd920$907e7580$b17b6080$@muller@ics-cnrs.unistra.fr>
On 12/13/2012 10:56 AM, Pierre Muller wrote:
>
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Pedro Alves
>> Envoyà : vendredi 7 dÃcembre 2012 18:49
>> Cc : Pierre Muller; 'asmwarrior'; 'Joel Brobecker'; 'Eli Zaretskii'; gdb-
>> patches@sourceware.org
>> Objet : Re: [RFC-v5] Fix .text section offset for windows DLL (was Calling
>> __stdcall functions in the inferior)
>>
>> On 12/07/2012 05:09 PM, Pedro Alves wrote:
>>> I haven't tried to grok the patch, but Kai tells me that a section name in
>> PE headers
>>> are stored in 8 character arrays, and are not necessarily zero-terminated.
>>> He was wondering, and now I am too, if it wouldn't be possible to make use
>>> of bfd routines to get at the necessary info, like the .text section
>> offset.
>>> E.g., bfd handles the long section name PE extension to coff (see
>> coffcode.h in
>>> bfd), though I'm not sure that needs to apply here.
>>
>> Hmm, looking at:
>>
...
> Pedro,
> you are right that my just committed patch does not
> fix the issue for windows gdbserver...
> So your idea to share the new function between gdb and gdbserver
> seemed indeed appealing, but when I looked at the new function pe_text_section_offset
> it doesn't seem so easy to me to remove bfd dependency...
>
> I will try to come up with a fix for gdbserver,
> but I am not sure it will be soon...
Thanks.
I'm still curious on why you needed the #ifndefs though.
There was also the point that section names in PE headers are stored in 8
character arrays, and are not necessarily zero-terminated -- get_pe_section_index
does strcmp without accounting for this (grep for SCNNMLEN in bfd).
--
Pedro Alves