Re: [PATCH 4/8] command 'set debug notification'.

[Pedro Alves <palves at redhat dot com>]

On 12/12/2012 06:59 PM, Eli Zaretskii wrote:
>> Date: Wed, 12 Dec 2012 17:56:52 +0000
>> From: Pedro Alves <palves@redhat.com>
>> CC: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
>>
>> On 12/11/2012 07:06 AM, Eli Zaretskii wrote:
>>>
>>>>> +  add_setshow_boolean_cmd ("notification", no_class, &notif_debug,
>>>>> +			   _("\
>>>>> +Set debugging of async remote notification."), _("\
>>>>> +Show debugging of async remote notification."), _("\
>>>>> +When non-zero, async remote notification specific"
>>>>> +" internal debugging is enabled."),
>>>      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> I think not "debugging" is enabled, but "debugging info" is enabled.
>>
>> This command just enables/disables internal debugging/logging output,
>> it is not about debug info, as in dwarf, etc.
> 
> Granted, I understand that.  If you suggest to say
> 
>   When non-zero, debugging output about async remote notifications is
>   enabled.
> 
> then I have no objections.  But saying that "internal debugging is
> enabled" is certainly inaccurate and perhaps even misleading, IMO.

I like that text, thanks.  Yao, the code parts are okay with that change.

Thanks,
-- 
Pedro Alves