This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add fseek to ui-file

From: Tom Tromey <tromey at redhat dot com>
To: Hui Zhu <teawater at gmail dot com>
Cc: gdb-patches ml <gdb-patches at sourceware dot org>, Hui Zhu <hui_zhu at mentor dot com>
Date: Mon, 10 Dec 2012 12:55:18 -0700
Subject: Re: [PATCH] Add fseek to ui-file
References: <CANFwon0Nv=Dk7-1kmxwjwv9zd-qoWUL18mpqH9vazRzBnkd10g@mail.gmail.com> <87txryx36w.fsf@fleche.redhat.com> <CANFwon31+VCzVWBvDLQedK0EGatd6XrRxaH1LbnHUtEKA91Ciw@mail.gmail.com> <87lid9x6hl.fsf@fleche.redhat.com> <CANFwon1PmXCeGNxJDCKpe+i+5L6CwZcJ-zC045S0CXiWHnepTg@mail.gmail.com>

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> Post a patch for that.  Please help me review it.

I think _p is not a super choice for a suffix.
It already has a meaning in gdb.
"_ptr" or most anything else would be better.

Tom

Follow-Ups:
- Re: [PATCH] Add fseek to ui-file
  - From: Hui Zhu
- Re: [PATCH] Add fseek to ui-file
  - From: Hui Zhu

References:
- [PATCH] Add fseek to ui-file
  - From: Hui Zhu
- Re: [PATCH] Add fseek to ui-file
  - From: Tom Tromey
- Re: [PATCH] Add fseek to ui-file
  - From: Hui Zhu
- Re: [PATCH] Add fseek to ui-file
  - From: Tom Tromey
- Re: [PATCH] Add fseek to ui-file
  - From: Hui Zhu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]