Re: [patch][python] 3 of 5 - Frame filter CLI/misc code changes.

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> --- a/gdb/data-directory/Makefile.in
Phil> +++ b/gdb/data-directory/Makefile.in

I don't think I saw a ChangeLog entry for this change, though I only
looked in this email.

Phil>  static void
Phil> -backtrace_command_1 (char *count_exp, int show_locals, int from_tty)
Phil> +backtrace_command_1 (char *count_exp, int show_locals, int raw,
Phil> +		     int from_tty)

Maybe it is time to change this to "flags" style, preferably using the
same enum that will be passed into Python.  If it actually makes sense
anyhow.

Phil> +	  if (raw_arg < 0 && subset_compare (argv[i], "raw"))

subset_compare seems really gross.
Let's change this to use more "ordinary" argument parsing somehow.
I suggest splitting on words using gdb_buildargv; we probably still have
to use subset_compare for "full" but we can avoid it at least for new
things.

Phil>    add_com ("backtrace", class_stack, backtrace_command, _("\
Phil>  Print backtrace of all stack frames, or innermost COUNT frames.\n\
Phil>  With a negative argument, print outermost -COUNT frames.\nUse of the \
Phil> -'full' qualifier also prints the values of the local variables.\n"));
Phil> +'full' qualifier also prints the values of the local variables.\n\
Phil> +Use of the 'raw' qualifier prohibits frame filters from executing\n\
Phil> +on this backtrace.\n"));

This is a good opportunity to add a Usage line.

Tom