This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands

From: Tom Tromey <tromey at redhat dot com>
To: Mircea Gherzan <mircea dot gherzan at intel dot com>
Cc: gdb-patches at sourceware dot org, keven dot boell at intel dot com, marc dot khouzam at ericsson dot com, vladimir at codesourcery dot com
Date: Thu, 29 Nov 2012 14:08:49 -0700
Subject: Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
References: <1354031591-20226-1-git-send-email-mircea.gherzan@intel.com> <87obiidfxl.fsf@fleche.redhat.com> <50B78BBB.1000907@intel.com>

>>>>> "Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:

>> It seems more consistent to me to suppress the notification and then
>> print the new breakpoint information as the result of this command.

Mircea> This has been fixed in v7 of the series.

There were some other review comments you haven't addressed yet: more
comments for the one function in breakpoint.c, and possible raciness in
the test case.

Tom

Follow-Ups:
- Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Mircea Gherzan

References:
- [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Mircea Gherzan
- Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Tom Tromey
- Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Mircea Gherzan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]