This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Rename breakpoints_changed to annotate_breakpoints_changed.


On 11/20/2012 05:54 PM, Pedro Alves wrote:
> This is the only extern function in annotate.c that doesn't have the
> "annotate_" prefix.
> 
> This function should probably be replaced by use of
> observer_notify_breakpoint_modified, but meanwhile, 

FYI:

The reason I'm looking at annotation code is that I made a change
that puts software single-step breakpoints in the regular breakpoint
chain, and then that triggers breakpoints-invalid annotations for
each sss breakpoint that didn't happen before, and in turn that
leads to the gdb.log getting filled up with useless notifications
and the tests timing out.  I had a small patch to handle this, but it turns
out incomplete.  Further looking at this issue, I've decided to go ahead
and fully convert the breakpoints-invalid annotation to observers.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]