This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 2/3] MI: document the -catch-load/-unload commands

From: Mircea Gherzan <mircea dot gherzan at intel dot com>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: gdb-patches at sourceware dot org, keven dot boell at intel dot com, marc dot khouzam at ericsson dot com, tromey at redhat dot com
Date: Tue, 20 Nov 2012 18:52:56 +0100
Subject: Re: [PATCH v3 2/3] MI: document the -catch-load/-unload commands
References: <1353336595-19986-1-git-send-email-mircea.gherzan@intel.com> <1353336595-19986-2-git-send-email-mircea.gherzan@intel.com> <83obity1kv.fsf@gnu.org>

On 19.11.2012 17:55, Eli Zaretskii wrote:

>+Add a catchpoint for library load events. If the @samp{-t} option is used,
>+the catchpoint is a temporary one. If the @samp{-d} option is used, the
>+catchpoint is created in a disabled state.

Two spaces between sentences, please (here and elsewhere in your
patch).

Also, will it be clear to the reader what does "temporary" mean?
Maybe you should add here a cross-reference to where catchpoints are
described, to cover that.

Thanks for your suggestions, I will include them in v4 of the patch.

Mircea

--

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

References:
- [PATCH v3 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Mircea Gherzan
- [PATCH v3 2/3] MI: document the -catch-load/-unload commands
  - From: Mircea Gherzan
- Re: [PATCH v3 2/3] MI: document the -catch-load/-unload commands
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]