This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Python 3 support, part 2 (testsuite part)


>>>>> "Paul" ==   <Paul_Koning@Dell.com> writes:

Paul> Most of the changes are for turning "print" from a statement into
Paul> a function call.  There are also some changes to handle the fact
Paul> that "str" is now Unicode and the separate "unicode" type is gone,
Paul> similarly "int" is now long integer and "long" is gone.

In the future, please split up patches like this.
The patch in its present form is difficult to read.
For example, all the "print" changes are obvious -- as a separate patch
those could get a simple "ok" without much fuss.

Paul> Ok to commit?

Yes, thanks.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]