This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] Remove AC_HEADER_STAT from configure.ac
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Pedro Alves'" <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 15 Nov 2012 15:58:55 +0100
- Subject: RE: [RFA] Remove AC_HEADER_STAT from configure.ac
- References: <50a4aadb.c54c420a.715f.5d53SMTPIN_ADDED@mx.google.com> <50A4C0C5.8020901@redhat.com> <000301cdc33c$f4203d20$dc60b760$@muller@ics-cnrs.unistra.fr> <50A4FD68.5080006@redhat.com>
> > I tried...
> > Here is the result.
> > Should we add stat.h to the list of checked headers?
>
> No need. gdb_stat.h includes sys/stat.h unconditionally.
>
> > I didn't find any HAVE_STAT_H occurrence,
> > and thus assumed this was unnecessary.
>
> > PS: In the regenerated files,
> > I discovered that configure has a strange, apparently unrelated
> > change... Is this normal?
>
> No. I just tried regenerating configure in the current
> mainline, with no changes to configure.ac, and configure
> did not change for me. Be sure to use pristine FSF autoconf 2.64.
> Sounds like the autoconf you used has local mingw patches.
>
> > 2012-11-15 Pierre Muller <muller@sourceware.org>
> >
> > * configure.ac (AC_HEADER_STAT): Remove.
> > * gdb_stat.h (STAT_MACROS_BROKEN): Remove macro use
> > and corresponding code.
> > * configure: Regenerate.
>
> Otherwise this is fine. Thanks.
I just manually removed the unwanted change to configure and
committed the rest.
Thanks for the approval,
Pierre