This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [OBV/committed] ARI fix: Remove #include "dirent.h" from common/linux-osdata.c
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Pedro Alves'" <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 8 Nov 2012 09:39:17 +0100
- Subject: RE: [OBV/committed] ARI fix: Remove #include "dirent.h" from common/linux-osdata.c
- References: <509a5653.a853420a.3131.fffff0a6SMTPIN_ADDED@mx.google.com> <509A9B21.1030106@redhat.com>
Sorry, forgot that rule
I already heard...
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé?: mercredi 7 novembre 2012 18:32
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [OBV/committed] ARI fix: Remove #include "dirent.h" from
> common/linux-osdata.c
>
> On 11/07/2012 12:38 PM, Pierre Muller wrote:
> > Current ARI lists one "dirent.h" rule error
> > in common/linux-osdata.c file.
> > http://sourceware.org/gdb/current/ari/
> >
> > But this file also includes gdb_dirent.h header,
> > thus I committed as obvious the removal of the "dirent.h" header.
> >
> > See:
> > http://sourceware.org/ml/gdb-cvs/2012-11/msg00046.html
>
> Please always post the patch instead of just the URL. Thanks.
Here is the patch:
ChangeLog entry:
2012-11-07 Pierre Muller <muller@sourceware.org>
* common/linux-osdata.c (dirent.h): ARI fix: Remove.
File already uses "gdb_dirent.h" header.
Index: common/linux-osdata.c
===================================================================
RCS file: /cvs/src/src/gdb/common/linux-osdata.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
--- common/linux-osdata.c 28 Jun 2012 23:44:26 -0000 1.6
+++ common/linux-osdata.c 7 Nov 2012 12:35:04 -0000 1.7
@@ -27,7 +27,6 @@
#include <sys/types.h>
#include <sys/stat.h>
-#include <dirent.h>
#include <ctype.h>
#include <stdlib.h>
#include <string.h>