This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] Modify trace-status output to always output stop-notes.
- From: "Abid, Hafiz" <Hafiz_Abid at mentor dot com>
- To: "Kozlov, Dmitry" <Dmitry_Kozlov at mentor dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Shebs, Stan" <Stan_Shebs at mentor dot com>
- Cc: "Prus, Vladimir" <Vladimir_Prus at mentor dot com>, "Qi, Yao" <Yao_Qi at mentor dot com>
- Date: Wed, 10 Oct 2012 12:40:13 +0000
- Subject: RE: [PATCH] Modify trace-status output to always output stop-notes.
- References: <50755958.5090107@mentor.com>
Just a small formatting nit.
+ else if (strncmp (p, "stop-notes", p1 - p) == 0)
+ {
+ ++p1;
+ ts->stop_desc= xmalloc (strlen (p) / 2);
A space is missing before =
+ end = hex2bin (p1, ts->stop_desc, (p3 - p1) / 2);
+ ts->stop_desc[end] = '\0';
+ p = p3;
+ }
Regards,
Abid
--
Hafiz Abid Qadeer
Mentor Graphics
hafiz_abid@mentor.com
+44 161 926 1630
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Kozlov, Dmitry
> Sent: Wednesday, October 10, 2012 12:18 PM
> To: gdb-patches@sourceware.org; Shebs, Stan
> Cc: Prus, Vladimir; Qi, Yao
> Subject: [PATCH] Modify trace-status output to always output stop-
> notes.
>
> Hi,
> accoriding to discussion in gdb mailing list I have added stop-notes as
> mandatory part of MI trace-status command. This makes processing of
> stop-notes on IDE side more uniform with trace-notes processing.
> Previously Yao mentioned that he implemented notifications that can be
> used to monitor trace-status, but putting stop-notes to trace-status
> looks more clear way because processing one extra trace-status
> parameter defferently from others.
>
> Stan, is it ok?
>
> Thank you