This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA/commit] Document exp_descriptor.op_name should never return NULL.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Wed, 3 Oct 2012 11:39:52 -0700
- Subject: [RFA/commit] Document exp_descriptor.op_name should never return NULL.
Hello,
This documents a constaint that struct exp_descriptor's "op_name"
method implementation should obey. This might not have been part
of the initial design, but is currently true of all instantiations,
and already assumed by the current users.
gdb/ChangeLog:
* parser-defs.h (struct exp_descriptor): Document constraint
on return value for "op_name" callbacks.
This is a patch that I thought I had sent a long time ago, but
apparently didn't. I'll commit in a few days unless someone objects.
Cheers,
--
Joel
---
gdb/parser-defs.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h
index 86f3bdf..c889d56 100644
--- a/gdb/parser-defs.h
+++ b/gdb/parser-defs.h
@@ -335,7 +335,10 @@ struct exp_descriptor
void *data),
void *data);
- /* Name of this operator for dumping purposes. */
+ /* Name of this operator for dumping purposes.
+ The returned value should never be NULL, even if EXP_OPCODE is
+ an unknown opcode (a string containing an image of the numeric
+ value of the opcode can be returned, for instance). */
char *(*op_name) (enum exp_opcode);
/* Dump the rest of this (prefix) expression after the operator
--
1.7.9.5