This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] new memory-changed MI notification.


On 09/29/2012 01:17 AM, Tom Tromey wrote:
Is there a particular reason to have two flags?
It seems one would do.

Usually I think it would be preferable to have a flag correspond to a
notification and not a command; but this would not work so well if a
command needed to suppress two different messages.  (Though if that
happens then maybe we should have a slightly different approach based on
bitmasks.)

Flag 'var_assign' would suppress two notifications, 'memory-changed' and 'register-changed' (to be posted later), because I feel hard to differentiate 'memory write' and 'register write' inside mi_cmd_var_assign and its callees.


Presently, looks only "-var-assign' may trigger two notifications, so I am not sure we have to switch to the new approach based on bitmask.

--
Yao


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]