This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
checked in: sol-thread.c: Remove commented-out code
> There's more '#if 0'-related code in the file. I think that if we're
> removing these, we should get rid of all of it.
Attached is the patch I checked in, removing all thise #if 0's.
The code inside them has been there since start of CVS...
gdb/ChangeLog:
* sol-thread.c (sol_thread_fetch_registers)
(sol_thread_store_registers): Delete commented out code.
Checked in.
--
Joel
>From 6c52bb3ac607244001e00fed5fc489fbabdaf53b Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 27 Sep 2012 12:40:38 +0200
Subject: [PATCH 2/2] sol-thread.c: Remove commented-out code.
gdb/ChangeLog:
* sol-thread.c (sol_thread_fetch_registers)
(sol_thread_store_registers): Delete commented out code.
---
gdb/ChangeLog | 5 +++++
gdb/sol-thread.c | 54 ------------------------------------------------------
2 files changed, 5 insertions(+), 54 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index aba3e0f..8faa029 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2012-09-27 Joel Brobecker <brobecker@adacore.com>
+ * sol-thread.c (sol_thread_fetch_registers)
+ (sol_thread_store_registers): Delete commented out code.
+
+2012-09-27 Joel Brobecker <brobecker@adacore.com>
+
* sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
Move these functions to sparc-sol-thread.c.
* sparc-sol-thread.c: New file.
diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
index 585a77f..bd31f4f 100644
--- a/gdb/sol-thread.c
+++ b/gdb/sol-thread.c
@@ -443,11 +443,6 @@ sol_thread_fetch_registers (struct target_ops *ops,
gdb_fpregset_t *fpregset_p = &fpregset;
struct target_ops *beneath = find_target_beneath (ops);
-#if 0
- int xregsize;
- caddr_t xregset;
-#endif
-
if (!is_thread (inferior_ptid))
{
/* It's an LWP; pass the request on to the layer beneath. */
@@ -488,23 +483,6 @@ sol_thread_fetch_registers (struct target_ops *ops,
supply_gregset (regcache, (const gdb_gregset_t *) gregset_p);
supply_fpregset (regcache, (const gdb_fpregset_t *) fpregset_p);
-
-#if 0
- /* FIXME: libthread_db doesn't seem to handle this right. */
- val = td_thr_getxregsize (&thandle, &xregsize);
- if (val != TD_OK && val != TD_NOXREGS)
- error (_("sol_thread_fetch_registers: td_thr_getxregsize %s"),
- td_err_string (val));
-
- if (val == TD_OK)
- {
- xregset = alloca (xregsize);
- val = td_thr_getxregs (&thandle, xregset);
- if (val != TD_OK)
- error (_("sol_thread_fetch_registers: td_thr_getxregs %s"),
- td_err_string (val));
- }
-#endif
}
static void
@@ -516,10 +494,6 @@ sol_thread_store_registers (struct target_ops *ops,
td_err_e val;
prgregset_t gregset;
prfpregset_t fpregset;
-#if 0
- int xregsize;
- caddr_t xregset;
-#endif
if (!is_thread (inferior_ptid))
{
@@ -557,23 +531,6 @@ sol_thread_store_registers (struct target_ops *ops,
/* Restore new register value. */
regcache_raw_supply (regcache, regnum, old_value);
-
-#if 0
- /* FIXME: libthread_db doesn't seem to handle this right. */
- val = td_thr_getxregsize (&thandle, &xregsize);
- if (val != TD_OK && val != TD_NOXREGS)
- error (_("sol_thread_store_registers: td_thr_getxregsize %s"),
- td_err_string (val));
-
- if (val == TD_OK)
- {
- xregset = alloca (xregsize);
- val = td_thr_getxregs (&thandle, xregset);
- if (val != TD_OK)
- error (_("sol_thread_store_registers: td_thr_getxregs %s"),
- td_err_string (val));
- }
-#endif
}
fill_gregset (regcache, (gdb_gregset_t *) &gregset, regnum);
@@ -587,17 +544,6 @@ sol_thread_store_registers (struct target_ops *ops,
if (val != TD_OK)
error (_("sol_thread_store_registers: td_thr_setfpregs %s"),
td_err_string (val));
-
-#if 0
- /* FIXME: libthread_db doesn't seem to handle this right. */
- val = td_thr_getxregsize (&thandle, &xregsize);
- if (val != TD_OK && val != TD_NOXREGS)
- error (_("sol_thread_store_registers: td_thr_getxregsize %s"),
- td_err_string (val));
-
- /* ??? Should probably do something about writing the xregs here,
- but what are they? */
-#endif
}
/* Perform partial transfers on OBJECT. See target_read_partial and
--
1.7.9.5