This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit][obv] Use TYPE_LENGTH directly where possible
On Wed, 26 Sep 2012 12:52:06 +0200, Joel wrote:
> I know it makes no functional difference, but it does make a
> noticeable difference in terms of maintenance, IMO. And I have in
> fact been silently grumbling about your patches being labeled
> "obvious" when in fact I do not consider them obvious. But I have let
> them go, because it wasn't significant enough that I felt I needed to
> talk about it.
>
> But this part of this patch in particular did catch my attention, and
> I feel that we need to discuss it. I think this goes in the wrong
> direction, and it would be better to just change the variable
> (constant???) type, rather than duplicate the expression everywhere.
> I don't have a strong opinion on this, and if other maintainers are ok
> with it, then OK. But in the meantime, I think the previous version
> was better.
OK, I'll revert this patch if anyone else objects as well. And thanks
for responding - I wouldn't have known otherwise and would have
assumed that these changes are generally acceptable.
Regards,
Siddhesh