Re: [PATCH] print threads name (bug # threads/12417)

[Mohsan Saleem <mohsansaleem_ms at yahoo dot com>]

I am placing thread name in quotation mark because in the output of 'info thread' the name of thread is in quotation.

While I was reading gdb manual I just found that for "info thread" there must be thread name in output, but wasn't there.
What should I do for my patch?
Because if we didn't assign a name to out thread then it will name it as the name of program(a.out etc).
So should I place "a.out" in it or any thing else?
?
--
Mohsan Saleem


----- Original Message -----
> From: Eli Zaretskii <eliz@gnu.org>
> To: Mohsan Saleem <mohsansaleem_ms@yahoo.com>
> Cc: gdb-patches@sourceware.org
> Sent: Tuesday, 25 September 2012 4:59 PM
> Subject: Re: [PATCH] print threads name (bug # threads/12417)
> 
>>  Date: Tue, 25 Sep 2012 01:28:19 -0700 (PDT)
>>  From: Mohsan Saleem <mohsansaleem_ms@yahoo.com>
>> 
>>  ? ? ?Attached patch is for bug 12417, for printing the name of threads 
> while printing the information of a thread.?
> 
> Thanks.
> 
>> ? if { [info exists thread6] } then {
>> ? ? ? gdb_test "thread find $thread6" \
>>  -??? "Thread 6 has .*$thread6.*" "find thread id 6"
>>  +??? "Thread 6 threadname_6 has .*$thread6.*" "find thread 
> id 6"
> 
> Isn't it better to have the name in parentheses?? Otherwise, how would
> the user know that this string is the name of the thread whose number
> precedes it?
> 
> Also, don't we need to update the manual, where thread notifications
> are described or shown in examples?
> 
> Finally, is this NEWS-worthy?
>